Arnaud HERITIER wrote:
Hi all,
It seems useful for some users to have a maven-sources-plugin for m1.
Are you agree if we add it in the m1 plugins ?
[ ] +1 - It seems to be a good idea.
[ ] +0 - Don't know
[ ] -1 - No, I prefer
+1
Arnaud

+1 definitely.

1/2/06, Arnaud HERITIER <aheritier (AT) gmail (DOT) comwrote:
Hi all,

It seems useful for some users to have a maven-sources-plugin for m1.

Are you agree if we add it in the m1 plugins ?

[ ] +1 - It seems to be a good idea.
[ ] +0 - Don't know
[ ] -1 - No, I prefer

Arnaud
--

We need a lightweight way to deploy source code on the repository. I
think the dist plugin is doing much more right?

s/

1/2/06, Arnaud HERITIER <aheritier (AT) gmail (DOT) comwrote:
It's the doubt I have actually.
We already publish project sources in the dist plugin.
I don't like to create a new project (we have already enough plugins to
maintain in m1) but it could be a good choice to mimic m2.

Arnaud
--
1/2/06, Lukas Theussl <ltheussl (AT) apache (DOT) orgwrote:

+0

Shouldn't this be part of the dist plugin? We'd just have to add some
goals like dist:source-deploy, dist:source-jar, etc?

-Lukas
--
Arnaud HERITIER wrote:
Hi all,

It seems useful for some users to have a maven-sources-plugin for m1.

Are you agree if we add it in the m1 plugins ?

[ ] +1 - It seems to be a good idea.
[ ] +0 - Don't know
[ ] -1 - No, I prefer

Arnaud
--

To unsubscribe, e-mail: dev-unsubscribe (AT) maven (DOT) apache.org
For additional commands, e-mail: dev-help (AT) maven (DOT) apache.org
>
>
>
>

Yes actually it deploys all the project sources tree (to allow a user to
rebuild it).
It's not the same goal.
It's why it could be better to create a new plugin.

Arnaud

1/3/06, Stephane Nicoll <stephane.nicoll (AT) gmail (DOT) comwrote:

We need a lightweight way to deploy source code on the repository. I
think the dist plugin is doing much more right?

s/

1/2/06, Arnaud HERITIER <aheritier (AT) gmail (DOT) comwrote:
It's the doubt I have actually.
We already publish project sources in the dist plugin.
I don't like to create a new project (we have already enough plugins to
maintain in m1) but it could be a good choice to mimic m2.

Arnaud
--
1/2/06, Lukas Theussl <ltheussl (AT) apache (DOT) orgwrote:

+0

Shouldn't this be part of the dist plugin? We'd just have to add some
goals like dist:source-deploy, dist:source-jar, etc?

-Lukas
--
Arnaud HERITIER wrote:
Hi all,

It seems useful for some users to have a maven-sources-plugin for
m1.

Are you agree if we add it in the m1 plugins ?

[ ] +1 - It seems to be a good idea.
[ ] +0 - Don't know
[ ] -1 - No, I prefer

Arnaud
--

To unsubscribe, e-mail: dev-unsubscribe (AT) maven (DOT) apache.org
For additional commands, e-mail: dev-help (AT) maven (DOT) apache.org
>
>
>
>
>
>

Think so too.
1/3/06, Arnaud HERITIER <aheritier (AT) gmail (DOT) comwrote:
Yes actually it deploys all the project sources tree (to allow a user to
rebuild it).
It's not the same goal.
It's why it could be better to create a new plugin.

Arnaud
--
1/3/06, Stephane Nicoll <stephane.nicoll (AT) gmail (DOT) comwrote:

We need a lightweight way to deploy source code on the repository. I
think the dist plugin is doing much more right?

s/

1/2/06, Arnaud HERITIER <aheritier (AT) gmail (DOT) comwrote:
It's the doubt I have actually.
We already publish project sources in the dist plugin.
I don't like to create a new project (we have already enough plugins to
maintain in m1) but it could be a good choice to mimic m2.

Arnaud
--
1/2/06, Lukas Theussl <ltheussl (AT) apache (DOT) orgwrote:

+0

Shouldn't this be part of the dist plugin? We'd just have to add some
goals like dist:source-deploy, dist:source-jar, etc?

-Lukas
--
Arnaud HERITIER wrote:
Hi all,

It seems useful for some users to have a maven-sources-plugin for
m1.

Are you agree if we add it in the m1 plugins ?

[ ] +1 - It seems to be a good idea.
[ ] +0 - Don't know
[ ] -1 - No, I prefer

Arnaud
--

To unsubscribe, e-mail: dev-unsubscribe (AT) maven (DOT) apache.org
For additional commands, e-mail: dev-help (AT) maven (DOT) apache.org
>
>
>
>
>
>

dowload is interesting. Example: IDE integration wants to download the
source from the repository. Should not fail if it is not available
though.

S

1/2/06, Arnaud HERITIER <aheritier (AT) gmail (DOT) comwrote:
I thought to jar, install and deploy.
I don't know if there's an interest to manually download it. It can be done
with a dependency.
I'll take a look at the m2 plugin to mimic it.

Arnaud

1/2/06, Fabrizio Giustina <fgiust (AT) apache (DOT) orgwrote:

+1

to mimic what we are able to do with m2 it should include the
following goals/tags:
jar
install
deploy
download

is this what you are planning to include in the plugin?
fabrizio
>
>
>
1/2/06, Arnaud HERITIER <aheritier (AT) gmail (DOT) comwrote:
Hi all,

It seems useful for some users to have a maven-sources-plugin for m1.

Are you agree if we add it in the m1 plugins ?

[ ] +1 - It seems to be a good idea.
[ ] +0 - Don't know
[ ] -1 - No, I prefer

Arnaud
>
>
>

To unsubscribe, e-mail: dev-unsubscribe (AT) maven (DOT) apache.org
For additional commands, e-mail: dev-help (AT) maven (DOT) apache.org
>
>
>
>

For example in mevenide/netbeans I'm downloading the sources not through
maven1 itself but manually for IDE plugin codebase. So a download goal not
really a requirement. However having to specify a special source dependency
for all binary deps sounds like a bit of overhead

Milos

1/5/06, Stephane Nicoll <stephane.nicoll (AT) gmail (DOT) comwrote:

dowload is interesting. Example: IDE integration wants to download the
source from the repository. Should not fail if it is not available
though.

S

1/2/06, Arnaud HERITIER <aheritier (AT) gmail (DOT) comwrote:
I thought to jar, install and deploy.
I don't know if there's an interest to manually download it. It can be
done
with a dependency.
I'll take a look at the m2 plugin to mimic it.

Arnaud

1/2/06, Fabrizio Giustina <fgiust (AT) apache (DOT) orgwrote:

+1

to mimic what we are able to do with m2 it should include the
following goals/tags:
jar
install
deploy
download

is this what you are planning to include in the plugin?
fabrizio
>
>
>
1/2/06, Arnaud HERITIER <aheritier (AT) gmail (DOT) comwrote:
Hi all,

It seems useful for some users to have a maven-sources-plugin for
m1.

Are you agree if we add it in the m1 plugins ?

[ ] +1 - It seems to be a good idea.
[ ] +0 - Don't know
[ ] -1 - No, I prefer

Arnaud
>
>
>

To unsubscribe, e-mail: dev-unsubscribe (AT) maven (DOT) apache.org
For additional commands, e-mail: dev-help (AT) maven (DOT) apache.org
>
>
>
>
>
>

I am thinking about, downloading source for everything or not at all
(that's why I am insist on the warning if the source is not found
instead of a failure :)

1/5/06, Milos Kleint <mkleint (AT) gmail (DOT) comwrote:
For example in mevenide/netbeans I'm downloading the sources not through
maven1 itself but manually for IDE plugin codebase. So a download goal not
really a requirement. However having to specify a special source dependency
for all binary deps sounds like a bit of overhead

Milos

1/5/06, Stephane Nicoll <stephane.nicoll (AT) gmail (DOT) comwrote:

dowload is interesting. Example: IDE integration wants to download the
source from the repository. Should not fail if it is not available
though.

S

1/2/06, Arnaud HERITIER <aheritier (AT) gmail (DOT) comwrote:
I thought to jar, install and deploy.
I don't know if there's an interest to manually download it. It can be
done
with a dependency.
I'll take a look at the m2 plugin to mimic it.

Arnaud

1/2/06, Fabrizio Giustina <fgiust (AT) apache (DOT) orgwrote:

+1

to mimic what we are able to do with m2 it should include the
following goals/tags:
jar
install
deploy
download

is this what you are planning to include in the plugin?
fabrizio
>
>
>
1/2/06, Arnaud HERITIER <aheritier (AT) gmail (DOT) comwrote:
Hi all,

It seems useful for some users to have a maven-sources-plugin for
m1.

Are you agree if we add it in the m1 plugins ?

[ ] +1 - It seems to be a good idea.
[ ] +0 - Don't know
[ ] -1 - No, I prefer

Arnaud
>
>
>

To unsubscribe, e-mail: dev-unsubscribe (AT) maven (DOT) apache.org
For additional commands, e-mail: dev-help (AT) maven (DOT) apache.org
>
>
>
>
>
>

1/5/06, Stephane Nicoll <stephane.nicoll (AT) gmail (DOT) comwrote:

I am thinking about, downloading source for everything or not at all
(that's why I am insist on the warning if the source is not found
instead of a failure :)

+1

Milos

1/5/06, Milos Kleint <mkleint (AT) gmail (DOT) comwrote:
For example in mevenide/netbeans I'm downloading the sources not through
maven1 itself but manually for IDE plugin codebase. So a download goal
not
really a requirement. However having to specify a special source
dependency
for all binary deps sounds like a bit of overhead

Milos

1/5/06, Stephane Nicoll <stephane.nicoll (AT) gmail (DOT) comwrote:

dowload is interesting. Example: IDE integration wants to download the
source from the repository. Should not fail if it is not available
though.

S

1/2/06, Arnaud HERITIER <aheritier (AT) gmail (DOT) comwrote:
I thought to jar, install and deploy.
I don't know if there's an interest to manually download it. It can
be
done
with a dependency.
I'll take a look at the m2 plugin to mimic it.

Arnaud

1/2/06, Fabrizio Giustina <fgiust (AT) apache (DOT) orgwrote:

+1

to mimic what we are able to do with m2 it should include the
following goals/tags:
jar
install
deploy
download

is this what you are planning to include in the plugin?
fabrizio
>
>
>
1/2/06, Arnaud HERITIER <aheritier (AT) gmail (DOT) comwrote:
Hi all,

It seems useful for some users to have a maven-sources-plugin
for
m1.

Are you agree if we add it in the m1 plugins ?

[ ] +1 - It seems to be a good idea.
[ ] +0 - Don't know
[ ] -1 - No, I prefer

Arnaud
>
>
>
>

To unsubscribe, e-mail: dev-unsubscribe (AT) maven (DOT) apache.org
For additional commands, e-mail: dev-help (AT) maven (DOT) apache.org
>
>
>
>
>
>

Guys,

V, the plugin has been committed in the plugins-sandbox.

It uses the maven.compile.src.set so any generated code (xdoclet, castor,
whathever) will be included automatically. Let me know what you guys think
and we will go further regarding IDE integration.

Thanks,
S

Thanks Stephane!

first comment: the artifact:install-snapshot and
artifact:deploy-snapshot tags are deprecated in the artifact plugin, I
think you can just remove these goals (just use a version with SNAPSHT)?
-Lukas

Stephane Nicoll wrote:
Guys,

V, the plugin has been committed in the plugins-sandbox.

It uses the maven.compile.src.set so any generated code (xdoclet, castor,
whathever) will be included automatically. Let me know what you guys think
and we will go further regarding IDE integration.

Thanks,
S

K, done.

Thx,
S

1/5/06, Lukas Theussl <ltheussl (AT) apache (DOT) orgwrote:

Thanks Stephane!

first comment: the artifact:install-snapshot and
artifact:deploy-snapshot tags are deprecated in the artifact plugin, I
think you can just remove these goals (just use a version with SNAPSHT)?

-Lukas
--
Stephane Nicoll wrote:
Guys,

V, the plugin has been committed in the plugins-sandbox.

It uses the maven.compile.src.set so any generated code (xdoclet,
castor,
whathever) will be included automatically. Let me know what you guys
think
and we will go further regarding IDE integration.

Thanks,
S
--

If we are all agree to push this plugin with other core plugins, I'll create
the project on Jira.

I'll test it this week.

Arnaud

1/5/06, Stephane Nicoll <stephane.nicoll (AT) gmail (DOT) comwrote:

K, done.

Thx,
S

1/5/06, Lukas Theussl <ltheussl (AT) apache (DOT) orgwrote:

Thanks Stephane!

first comment: the artifact:install-snapshot and
artifact:deploy-snapshot tags are deprecated in the artifact plugin, I
think you can just remove these goals (just use a version with
SNAPSHT)?

-Lukas
--
Stephane Nicoll wrote:
Guys,

V, the plugin has been committed in the plugins-sandbox.
--

It uses the maven.compile.src.set so any generated code (xdoclet,
castor,
whathever) will be included automatically. Let me know what you guys
think
and we will go further regarding IDE integration.

Thanks,
S
--

Brett,

Yep. Any pointer to the m2 implementation please?

s/

1/5/06, Brett Porter <brett (AT) apache (DOT) orgwrote:

Just one comment if you start to implement download as part of idea:idea
or eclipse:eclipse - please make sure it is consistent with the m2
implementation.

Stephane Nicoll wrote:
dowload is interesting. Example: IDE integration wants to download the
source from the repository. Should not fail if it is not available
though.
--

To unsubscribe, e-mail: dev-unsubscribe (AT) maven (DOT) apache.org
For additional commands, e-mail: dev-help (AT) maven (DOT) apache.org
--

Brett Porter wrote:
Just one comment if you start to implement download as part of idea:idea
or eclipse:eclipse - please make sure it is consistent with the m2
implementation.

Stephane Nicoll wrote:
>dowload is interesting. Example: IDE integration wants to download the
>source from the repository. Should not fail if it is not available
>though.

Milos is doing this in the Netbeans integration. All the IDE integration
should use the same library, possibly the embedder as that will give you
the same behaviour as maven itself.

To unsubscribe, e-mail: dev-unsubscribe (AT) maven (DOT) apache.org
For additional commands, e-mail: dev-help (AT) maven (DOT) apache.org

1/5/06, Jason van Zyl <jason (AT) maven (DOT) orgwrote:

Brett Porter wrote:
Just one comment if you start to implement download as part of idea:idea
or eclipse:eclipse - please make sure it is consistent with the m2
implementation.

Stephane Nicoll wrote:
>dowload is interesting. Example: IDE integration wants to download the
>source from the repository. Should not fail if it is not available
>though.
>
Milos is doing this in the Netbeans integration. All the IDE integration
should use the same library, possibly the embedder as that will give you
the same behaviour as maven itself.

I'll synchronize with Milos Then.

S

You can look at EclipsePlugin and EclipseUtils in the m2 eclipse plugin:

Actually in m2 the code to download a source artifact is simple, using
artifact resolver:

Artifact resolvedArtifact =
( artifact.getGroupId(),
artifact.getArtifactId(), artifact.getVersion(), "java-source",
"sources");

try
{
// resolve in local repo or try to download if not already available
artifactResolver.resolve( resolvedArtifact, remoteRepos,
localRepository );
}
catch ( ArtifactNotFoundException e )
{
// ignore, source jar not found
}

the same also is valid for javadoc attachements (I recently added
javadoc archives handling to the m2 eclipse plugin too)

fabrizio

1/5/06, Stephane Nicoll <stephane.nicoll (AT) gmail (DOT) comwrote:
Brett,

Yep. Any pointer to the m2 implementation please?

s/

1/5/06, Brett Porter <brett (AT) apache (DOT) orgwrote:

Just one comment if you start to implement download as part of idea:idea
or eclipse:eclipse - please make sure it is consistent with the m2
implementation.

Stephane Nicoll wrote:
dowload is interesting. Example: IDE integration wants to download the
source from the repository. Should not fail if it is not available
though.
--

To unsubscribe, e-mail: dev-unsubscribe (AT) maven (DOT) apache.org
For additional commands, e-mail: dev-help (AT) maven (DOT) apache.org
>
>
>
>

K. But would it be possible to have some common place for this piece of
code. It will be used by the eclipse and IDEA plugin anyway.

WDYT?

S

1/6/06, Milos Kleint <mkleint (AT) gmail (DOT) comwrote:

actually this is for maven1 integration. I don't use the embedder there
and
I don't plan to actually, using plain commons-httpclient there

in m2 impl, the embedder is used to download the sources

Milos
--
1/5/06, Jason van Zyl <jason (AT) maven (DOT) orgwrote:

Brett Porter wrote:
Just one comment if you start to implement download as part of
idea:idea
or eclipse:eclipse - please make sure it is consistent with the m2
implementation.

Stephane Nicoll wrote:
>dowload is interesting. Example: IDE integration wants to download
the
>source from the repository. Should not fail if it is not available
>though.
>
Milos is doing this in the Netbeans integration. All the IDE integration
should use the same library, possibly the embedder as that will give you
the same behaviour as maven itself.
--

To unsubscribe, e-mail: dev-unsubscribe (AT) maven (DOT) apache.org
For additional commands, e-mail: dev-help (AT) maven (DOT) apache.org
>
>
>
>
>
--

jvz.

Jason van Zyl
jason at maven.org
http://maven.apache.org

A man enjoys hsi work when he understands the whole and when he
is responsible for the quality of the whole

-- Christopher Alexander, A Pattern Language

To unsubscribe, e-mail: dev-unsubscribe (AT) maven (DOT) apache.org
For additional commands, e-mail: dev-help (AT) maven (DOT) apache.org
>
>
>
>