Thu, Jul 06, 2006 at 11:33:57AM +0200, Tomasz Chmielewski wrote:
>I am not a regular samba developer, but I wanted to have psexec
>equivalent, so I wrote it, it works but still need some development.
>I do not know if patches of such sizes (about 30k) are welcome on
>this list so I've put it on web page, with some description:
>http://eol.ovh.org/winexe/
>Comments welcome.

Hi, this is really great, you can get Windows command line (cmd) in your
Linux shell:

[tch@tomek Desktop]$ uname -r
2.6.16-1mdk
[tch@tomek Desktop]$ ./winexe -W LAPTK -U Administrator
//192.168.151.11 "cmd.exe"
Password for [LAPTK\Administrator]:
Microsoft Windows XP [Version 5.1.2600]
(C) Copyright 1985-2001 Microsoft Corp.

C:\WINDWS\system32>ver
ver

Microsoft Windows XP [Version 5.1.2600]

C:\WINDWS\system32>

I'm sending this also to samba list, this tool has been very often
requested on various Samba groups.

Tomasz, can you please post this patch to the samba-technical
list rather than leaving it on a web page. That way it's unambiguous
that you want to donate it to Samba under the GPL.

Thanks,

Jeremy.

Thu, Jul 06, 2006 at 06:44:18PM +0200, Tomasz Chmielewski wrote:
Jeremy Allison wrote:

()

>>I'm sending this also to samba list, this tool has been very often
>>requested on various Samba groups.
>
>Tomasz, can you please post this patch to the samba-technical
>list rather than leaving it on a web page. That way it's unambiguous
>that you want to donate it to Samba under the GPL.

I meant (sending) the announcement (to samba list), because originally
it was only sent to samba-technical.

The author (Andrzej Hajda) sent the patch to samba-technical already:

No, he sent a link to his web page to Samba technical already.
I haven't seen the patch on samba-technical, that's what we need
to see in order to be able to accept it.

Thanks,

Jeremy.

Thu, Jul 06, 2006 at 07:30:06PM +0200, Jelmer Vernooij wrote:

He did send the diff to the IDL file, which I've just applied.

Yes I saw that.

However, I'm not too keen on putting in the winexe patch (at least not
in the current state I think linking a Windows binary into Samba is a
very very bad idea.

Indeed :-).

Also, there are also other minor issues:

* Code style
* Use of // for comments
* Use of manually written prototypes in the C files
* Use of direct headers (<termios.h>, etc) instead of <system/xx.h>
* CamelCasing
* The Windows code should (imho) go in some different place
* Even /if/ we did think including a .exe in Samba was ok, 'winexe'
should be made optional because we don't want to require people to
install MSVC in order to build Samba.

These are minor things we can easily fix. I just don't want
this to get lost as it looks to provide significant functionality
for people.

Jeremy.

Thu, Jul 06, 2006 at 10:52:18PM +0200, AH wrote:

Thanks for comments.
I am still working on winexe, for now I publish code on
http://eol.ovh.org/winexe/.

Thanks, but we shouldn't pick your code up from a website,
we need to have it donated by posting to the list.

If people on this list are interested I can send info about progress, or
even post patches.

That would be great - thanks !

Jeremy.

Jelmer Vernooij:
However, I'm not too keen on putting in the winexe patch (at least not
in the current state I think linking a Windows binary into Samba is a
very very bad idea.

Also, there are also other minor issues:

* Code style
* Use of // for comments
* Use of manually written prototypes in the C files
* Use of direct headers (<termios.h>, etc) instead of <system/xx.h>
* CamelCasing
* The Windows code should (imho) go in some different place
* Even /if/ we did think including a .exe in Samba was ok, 'winexe'
should be made optional because we don't want to require people to
install MSVC in order to build Samba.

Thanks for comments.
I am still working on winexe, for now I publish code on
http://eol.ovh.org/winexe/.
If people on this list are interested I can send info about progress, or
even post patches.

course I agree about style and others ( I need to find out how to
make prototypes auto generated).
Many things I will correct by myself, but for many I need advice, I hope
to find it on this list.

About compiling windows code - I have never used MSVC to compile it, at
the beginning I've used Cygwin,
but now I compile everything in Linux. course I have installed
crosscompiler, below list of rpm packages (PLD distro):
crossmingw32-gcc-c3.4.3-4
crossmingw32-runtime-3.7-1
crossmingw32-gcc-3.4.3-4
crossmingw32-w32api-3.2-1

So this is some dependency, but not such big as MSVC :)

And about integrating it with samba - it would be nice, we can work on it :)

Andrzej Hajda

Thu, Jul 06, 2006 at 11:27:55PM +0200, Henrik Zagerholm wrote:
Hi and thanks AH for a very good initiative of building this kind of
tool.
I just wonder if it would be possible to port this to the SAMBA 3
branch?

Yes it would be quite easy, but AH needs to post his patch
to the list so we can work on it first.

Thanks,

Jeremy.