Hello!

Mon, Aug 28, 2006 at 03:26:55AM +0200, Stefan Siegl wrote:
The patch along adds yet another configure option (enable-pcmcia-isa),
allowing to compile that bits in. The latter is especially useful if
your PCMCIA bridge, attached to the PCI bus, doesn't get an IRQ itself.
In this case the PCMCIA core does not know which IRQ to assign unless an
(ISA) IRQ scan takes place.

Please add a short snippet to i386/README-Drivers as well and then commit
the whole lot; the ChangeLog addition should perhaps look like this:

[current date] Stefan Siegl <stesie (AT) brokenpipe (DOT) de>

* i386/linux/configure: Regenerate.
* Likewise.

* i386/linux/configure.ac (AC_PCMCIAPTIN): New function.
(): New configuration option to enable ISA-bus
support in the pcmcia core.
* doc/mach.texi (Configuration): Briefly document the new configuration
option.
* i386/README-Drivers: Likewise.

compared to yours:

2006-08-28 Stefan Siegl <stesie (AT) brokenpipe (DOT) de>

* i386/linux/configure.ac: Add configuration option allowing to enable
ISA-bus support in the pcmcia core.

* i386/linux/configure: Regenerate.
* Likewise.

* doc/mach.texi (Configuration): Briefly document the new configuration
option.

This means: group together (i.e. without new-lines in between) stuff that
belongs together (the new option and its documentation) and
(chronologically) _after_ that (which will be _above_ in the ChangeLog)
the regeneration of the compiled files. You could even do the actual
patch and the regeneration of the files as separate commits (also to make
sure that the regenerated files have more recent time stamps -- no idea
if cvs deals with that correctly otherwise).

Regards,
Thomas

Bug-hurd mailing list
Bug-hurd (AT) gnu (DOT) org

PGP SIGNATURE
Version: GnuPG v1.2.5 (GNU/Linux)

YVj1p8ya8j7oNQBUKg2epaw=
=JtN6
PGP SIGNATURE

Mon, Sep 18, 2006 at 09:37:05PM +0200, Thomas Schwinge wrote:
* i386/linux/configure: Regenerate.
* Likewise.

* i386/linux/configure.ac (AC_PCMCIAPTIN): New function.

I thought one mentiones the configure: Regenerate after what prompted
the regeneration in the first place. Don't know whether the GCS have
anything to say on this, though.

Michael

Bug-hurd mailing list
Bug-hurd (AT) gnu (DOT) org

Hello!

Tue, Sep 19, 2006 at 12:58:25AM +0200, Michael Banck wrote:
Mon, Sep 18, 2006 at 09:37:05PM +0200, Thomas Schwinge wrote:
* i386/linux/configure: Regenerate.
* Likewise.

* i386/linux/configure.ac (AC_PCMCIAPTIN): New function.

I thought one mentiones the configure: Regenerate after what prompted
the regeneration in the first place.

Here is my version:

ChangeLog entries that have an empty line between them are independent of
each other. (I admit that one could argue whether regenerating a
compiled file is independent of changing its source file or not, but in
my book it is.) Now, you change such a source file configure.ac
and commit that change.

#v+
[Date.] [Who.] [Where.]

* configure.ac: Foo.
#v-
Afterwards you regenerate the compiled file configure and commit
that change. Then the ChangeLog looks like this:

#v+
[Date.] [Who.] [Where.]

* configure: Regenerate.

* configure.ac: Foo.
#v-
course, committing the whole lot directly as

#v+
[Date.] [Who.] [Where.]

* configure.ac: Foo.
* configure: Regenerate.
#v-
wouldn't be wrong either, but as I said, I don't know if the files's
time stamps will be alright then.

Don't know whether the GCS have anything to say on this, though.

<>.

``6.8.1 Change Log Concepts

You can think of the change log as a conceptual undo which
explains how earlier versions were different from the current version.

[]

6.8.2 Style of Change Logs

[]

Separate unrelated change log entries with blank lines. When two entries
represent parts of the same change, so that they work together, then
don't put blank lines between them.''

Regards,
Thomas

Bug-hurd mailing list
Bug-hurd (AT) gnu (DOT) org

PGP SIGNATURE
Version: GnuPG v1.2.5 (GNU/Linux)

CfXs3dAxK7zYanSJn8wtPmQ=
=Mkop
PGP SIGNATURE

Hello!

Sat, Sep 23, 2006 at 10:45:21PM +0200, StefanSiegl wrote:
Since meanwhile you've changed configure.ac to enable must stuff by
default, I adjusted the AC_PCMCIAPTIN to behave like this as well.

Fine.

I just committed the following:

2006-09-23 Stefan Siegl <stesie (AT) brokenpipe (DOT) de>
[]
(): New configuration option to disable ISA-bus
support in the pcmcia core, which is otherwise enabled now by default.

thing I just stumbled about: this #define is plainly called
CNFIG_ISA. I wouldn't have expected that this (having a really
universal name) is only used within the pcmcia code, but that's how it
is, it seems at least for Linux 2.0 and 2.2 code.

Regards,
Thomas

Bug-hurd mailing list
Bug-hurd (AT) gnu (DOT) org

PGP SIGNATURE
Version: GnuPG v1.2.5 (GNU/Linux)

LS5cTtWu3kgD/U4v2qW8eY0=
=NpYi
PGP SIGNATURE