Hello,
I want Kate's suck factor reach an all-time low. Therefore, I'm preparing some
patches against 3.5 to approach that goal.
The first strike is a repost of attachment
of bug
It fixes all problems mentioned
therein.
Please review. I'd like to commit the fix as soon as I've got green light.
mfg
Leo
KWrite-Devel mailing list
KWrite-Devel (AT) kde (DOT) org
PGP SIGNATURE
Version: GnuPG v1.2.5 (GNU/Linux)
m+lCNv6RoBfANZuaM4Cc=
=rIx6
PGP SIGNATURE

Am Dienstag, 22. August 2006 21:35 schrieb Leo Savernik:
Hello,

I want Kate's suck factor reach an all-time low. Therefore, I'm preparing
some patches against 3.5 to approach that goal.

The first strike is a repost of attachment
of bug
It fixes all problems mentioned
therein.

Please review. I'd like to commit the fix as soon as I've got green light.
From just looking at it, see no probs, have no 3.5 branch around as said, if
it works for you, commit it, but please forwardport the fixes to /trunk,
too ;)

KWrite-Devel mailing list
KWrite-Devel (AT) kde (DOT) org

Tuesday 22 August 2006 21:35, Leo Savernik wrote:
Hello,

I want Kate's suck factor reach an all-time low. Therefore, I'm preparing
some patches against 3.5 to approach that goal.

The first strike is a repost of attachment
of bug
It fixes all problems
mentioned therein.

Please review. I'd like to commit the fix as soon as I've got green
light.

mfg
Leo

First of all: Thanks for looking into this, it's been annoying me for ages
as well :)

I tested the patch and it works better than before. just a small glitch:

[]
static const QString firstTriggers("}{)/:#"); // NTE the '/'
[]

if (c == '/')
{
[]
return;
}
[]

Now you test for firstTriggers.find( firstChar ). FirstTriggers contains '/'
but this will never match as it already matched in the if (c == '/').

If we want //-comments to be aligned you have to change that :)
oh well, the question should rather be: Does it increase or lower Kate's
suck factor? ;)

Please don't forget to port to trunk.

Thanks,
Dominik

KWrite-Devel mailing list
KWrite-Devel (AT) kde (DOT) org

Am Mittwoch, 23. August 2006 18:27 schrieb Dominik Haumann:
just a small glitch:

[]
static const QString firstTriggers("}{)/:#"); // NTE the '/'
[]

if (c == '/')
{
********[]
********return;
}
[]

Now you test for firstTriggers.find( firstChar ). FirstTriggers contains
'/' but this will never match as it already matched in the if (c == '/').

Excellent.

If we want //-comments to be aligned you have to change that :)
oh well, the question should rather be: Does it increase or lower Kate's
suck factor? ;)

Massively increase, I guess :-) Comments shouldn't actually cause any
reindentation (except for doxygen, which is handled extra). So everthing's
perfect.

Please don't forget to port to trunk.

I'm afraid I can't switch to KDE 4 before Christmas 2007. Maybe someone else
can forwardport earlier.

mfg
Leo

KWrite-Devel mailing list
KWrite-Devel (AT) kde (DOT) org