Additional Comments From tj (AT) castaglia (DOT) org 2005-12-02 19:05 Eastern
Created an attachment (id=2425)
()
Fixes bug (hopefully)
Here's a slightly different version of your patch. The main difference is
changing:
if (auth_pam_module.authtable->auth_flags & PR_AUTH_FL_REQUIRED)
to:
if (auth_pam_authtab[0].auth_flags & PR_AUTH_FL_REQUIRED)
The previous line's use of auth_pam_module.authtable makes an assumption about
the number of elements in that array; the second version assumes that the
element in question is at index 0, and accesses the authtable structure
directly, rather than going through the auth_pam_module struct (which is a
little clearer, from a legibility standpoint).Does this make sense? Would
you mind testing this patch, verifying that it works correctly for you?