hello,
the patch generator is completely haywire, so just remarks:
- the trolltech entry contains a line for suse
- in the mandriva entry should be a , instead of a . after faure

[ Buddenhagen ]
the patch generator is completely haywire, so just remarks:

Is this really a bug report written by a programmer? ;-)

The one problem that I know is that email clients break huge lines by default,
and that there is no automatic way to tell KMail to switch off line-breaking.
But we have managed to deal with it so far, and if you want to send something
perfect than you can use the option in the KMail composer or save the patch
to disk and send it as an attachment.

Any other problems that you encountered?

Sat, May 13, 2006 at 12:09:17PM +0200, Schmidt wrote:
[ Buddenhagen ]
the patch generator is completely haywire, so just remarks:

Is this really a bug report written by a programmer? ;-)

yes. going through the procedure yourself just *has* to reveal it, so
why should i be precise? :-P

The one problem that I know is that email clients break huge lines by
default,

no. the formatting is perfect. i'd be just too interested in knowing
what it is diffing - certainly not my changes.

[ Buddenhagen ]
now it hangs entirely when i hit the "preview" button.
I cannot reproduce this. Please be more specific.

[ Buddenhagen ]
no. the formatting is perfect. i'd be just too interested in knowing
what it is diffing - certainly not my changes.

The diffing algorithm got confused by a wrong encoded "" in the original
page. After fixing this (and the mistakes you reported, and an additional
typo I also found), the diffing algorithm works fine again on that page.

I will have a look whether I can make the edit function refuse to work of
there is an encoding error.

Thanks for reporting.

Sat, May 13, 2006 at 12:38:58PM +0200, Schmidt wrote:
[ Buddenhagen ]
no. the formatting is perfect. i'd be just too interested in knowing
what it is diffing - certainly not my changes.

The diffing algorithm got confused by a wrong encoded "" in the original
page. After fixing this (and the mistakes you reported, and an additional
typo I also found), the diffing algorithm works fine again on that page.

now it hangs entirely when i hit the "preview" button.

Sat, May 13, 2006 at 01:01:15PM +0200, Schmidt wrote:
[ Buddenhagen ]
now it hangs entirely when i hit the "preview" button.
I cannot reproduce this. Please be more specific.
Fatal error: Maximum execution time of 30 seconds exceeded in / on line 60

Sat, May 13, 2006 at 04:24:04PM +0200, Marcos Fouces wrote:
Buddenhagen wrote:
Sat, May 13, 2006 at 01:01:15PM +0200, Schmidt wrote:
>>[ Buddenhagen ]
now it hangs entirely when i hit the "preview" button.
>>I cannot reproduce this. Please be more specific.
>>
>Fatal error: Maximum execution time of 30 seconds exceeded in
>/ on line 60
>

Argh! You are right! I have not seen the page bottom.

Seems to me that it is necessary to increase max_execution_time value in
php conf file.

but 30 seconds for a diff? when the server otherwise responds within
milliseconds? i tend to think that increasing the timeout is not the
right solution

[ Marcos Fouces ]
I am testing right now the preview function and it works well.

I also had the problem that I could not reproduce it. then told me that
you need to make any changes at the end of the text. Again, I could not
reproduce it. Then I removed the last paragraph (instead of changing it or
adding text), and I got the error.

I am not sure how to fix this, though.