Change 24688 by steveh@steveh-TANGARA on 2005/06/03 08:12:45
Subject: [PATCH] Run ICMP ping tests on Windows as long as we have admin privs
From: "Jan Dubois" <jand (AT) ActiveState (DOT) com>
Date: Mon, 18 Apr 2005 20:16:24 -0700
Message-Id: <200504190311.j3J3BM4p001792 (AT) smtp3 (DOT) ActiveState.com>
Subject: RE: [PATCH] Run ICMP ping tests on Windows as long as we have admin privs
From: "Jan Dubois" <jand (AT) ActiveState (DOT) com>
Date: Tue, 19 Apr 2005 01:49:51 -0700
Message-Id: <200504190844.j3J8inkW032630 (AT) smtp3 (DOT) ActiveState.com>
(There was no reply from Rob Brown in over a month, so commit to blead
for now. I'll email him again)
Affected files
//depot/perl/lib/Net/Ping.pm#44 edit
//#12 edit
//#2 edit
Differences
//depot/perl/lib/Net/Ping.pm#44 (text)
Index: perl/lib/Net/Ping.pm
perl/lib/Net/Ping.pm#43~20451~Sun Aug 3 11:24:18 2003
perl/lib/Net/Ping.pmFri Jun 3 01:12:45 2005
@@ -16,7 +16,7 @@
@ISA = qw(Exporter);
@EXPRT = qw(pingecho);
-$VERSIN = "2.31";
+$VERSIN = "2.31_01";
sub SL_IP { 0; };
sub IP_TS { 1; };
//#12 (text)
Index:
#11~18038~Sun 20 07:23:06 2002
Fri Jun 3 01:12:45 2005
@@ -17,7 +17,7 @@
if (($and $^ ne 'VMS' and $^ ne 'cygwin')
or ($^ eq 'MSWin32'
- and Win32::IsWinNT())
+ and !IsAdminUser())
or ($^ eq 'VMS'
and (`write sys\$output f\$privilege("SYSPRV")` =~ m/FALSE/))) {
skip "icmp ping requires root privileges.", 1;
@@ -26,4 +26,11 @@
} else {
my $p = new Net::Ping "icmp";
ok !!$p;
+}
+
+sub IsAdminUser {
+ return unless $^ eq 'MSWin32';
+ return unless eval { require Win32 };
+ return unless defined &Win32::IsAdminUser;
+ return Win32::IsAdminUser();
}
//#2 (text)
Index:
#1~18671~Sat Feb 8 00:35:06 2003
Fri Jun 3 01:12:45 2005
@@ -17,7 +17,7 @@
if (($and $^ ne 'VMS' and $^ ne 'cygwin')
or ($^ eq 'MSWin32'
- and Win32::IsWinNT())
+ and !IsAdminUser())
or ($^ eq 'VMS'
and (`write sys\$output f\$privilege("SYSPRV")` =~ m/FALSE/))) {
skip "icmp ping requires root privileges.", 1;
@@ -26,4 +26,11 @@
} else {
my $p = new Net::Ping "icmp";
ok $p->ping("127.0.0.1");
+}
+
+sub IsAdminUser {
+ return unless $^ eq 'MSWin32';
+ return unless eval { require Win32 };
+ return unless defined &Win32::IsAdminUser;
+ return Win32::IsAdminUser();
}
End of Patch.

Fri, Jun 03, 2005 at 01:43:40AM -0700, Steve Hay wrote:
Change 24688 by steveh@steveh-TANGARA on 2005/06/03 08:12:45

Subject: [PATCH] Run ICMP ping tests on Windows as long as we have admin privs
From: "Jan Dubois" <jand (AT) ActiveState (DOT) com>
Date: Mon, 18 Apr 2005 20:16:24 -0700
Message-Id: <200504190311.j3J3BM4p001792 (AT) smtp3 (DOT) ActiveState.com>

Subject: RE: [PATCH] Run ICMP ping tests on Windows as long as we have admin privs
From: "Jan Dubois" <jand (AT) ActiveState (DOT) com>
Date: Tue, 19 Apr 2005 01:49:51 -0700
Message-Id: <200504190844.j3J8inkW032630 (AT) smtp3 (DOT) ActiveState.com>

(There was no reply from Rob Brown in over a month, so commit to blead
for now. I'll email him again)

Has there been any response from Rob Brown?

Nicholas Clark

Sat, Nov 12, 2005 at 11:26:09AM +0000, Nicholas Clark wrote:
Fri, Jun 03, 2005 at 01:43:40AM -0700, Steve Hay wrote:
Change 24688 by steveh@steveh-TANGARA on 2005/06/03 08:12:45

Subject: [PATCH] Run ICMP ping tests on Windows as long as we have admin privs
From: "Jan Dubois" <jand (AT) ActiveState (DOT) com>
Date: Mon, 18 Apr 2005 20:16:24 -0700
Message-Id: <200504190311.j3J3BM4p001792 (AT) smtp3 (DOT) ActiveState.com>

Subject: RE: [PATCH] Run ICMP ping tests on Windows as long as we have admin privs
From: "Jan Dubois" <jand (AT) ActiveState (DOT) com>
Date: Tue, 19 Apr 2005 01:49:51 -0700
Message-Id: <200504190844.j3J8inkW032630 (AT) smtp3 (DOT) ActiveState.com>

(There was no reply from Rob Brown in over a month, so commit to blead
for now. I'll email him again)

Has there been any response from Rob Brown?

Checking on CPAN, Rob Brown hasn't updated his old modules in a while. He
did release a script to CPAN that has a different email listed than what
is in the Net::Ping module. According to ttylog, his email address is
rob (AT) asquad (DOT) com.

Steve Peters
steve (AT) fisharerojo (DOT) org

Steve Peters wrote:
Sat, Nov 12, 2005 at 11:26:09AM +0000, Nicholas Clark wrote:

>Fri, Jun 03, 2005 at 01:43:40AM -0700, Steve Hay wrote:
>>
Change 24688 by steveh@steveh-TANGARA on 2005/06/03 08:12:45

Subject: [PATCH] Run ICMP ping tests on Windows as long as we have admin privs
From: "Jan Dubois" <jand (AT) ActiveState (DOT) com>
Date: Mon, 18 Apr 2005 20:16:24 -0700
Message-Id: <200504190311.j3J3BM4p001792 (AT) smtp3 (DOT) ActiveState.com>

Subject: RE: [PATCH] Run ICMP ping tests on Windows as long as we have admin privs
From: "Jan Dubois" <jand (AT) ActiveState (DOT) com>
Date: Tue, 19 Apr 2005 01:49:51 -0700
Message-Id: <200504190844.j3J8inkW032630 (AT) smtp3 (DOT) ActiveState.com>

(There was no reply from Rob Brown in over a month, so commit to blead
for now. I'll email him again)
>>
>>Has there been any response from Rob Brown?

No, I didn't get any reply.

>>

Checking on CPAN, Rob Brown hasn't updated his old modules in a while. He
did release a script to CPAN that has a different email listed than what
is in the Net::Ping module. According to ttylog, his email address is
rob (AT) asquad (DOT) com.

Ah, thanks. I'll try emailing him there then.

Radan Computational Ltd.

The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only. If you have received this message in error or there are any problems, please notify the sender immediately. The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden. Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd. The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email.