Summary: tests fail due to LANGUAGE environment variable
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: PC
S/Version: Linux
Status: NEW
Severity: trivial
Priority: P5
Component: Regression Tests
AssignedTo: dev (AT) spamassassin (DOT) apache.org
ReportedBy: japh (AT) tirwhan (DOT) org
Tests in gtube.t and reportheader.t fail if the system environment variable
LANGUAGE is set to a non-English language. The tests set $ENV{LC_ALL} to
counter this, but since LANGUAGE has precedence over LC_ALL this does not
work.
Solution: set $ENV{LANGUAGE} instead of $ENV{LC_ALL}
You are receiving this mail because:
You are the assignee for the bug, or are watching the assignee.

Additional Comments From japh (AT) tirwhan (DOT) org 2006-08-12 11:17
Created an attachment (id=3635)
()
Example of failed test output
You are receiving this mail because:
You are the assignee for the bug, or are watching the assignee.

Additional Comments From japh (AT) tirwhan (DOT) org 2006-08-12 11:20
Created an attachment (id=3636)
()
patch

This also changes tests that do _not_ fail, for the sake of consistency.

You are receiving this mail because:
You are the assignee for the bug, or are watching the assignee.

felicity (AT) apache (DOT) org changed:
What |Removed |Added
Target Milestone|Undefined |3.1.5
You are receiving this mail because:
You are the assignee for the bug, or are watching the assignee.

Additional Comments From sidney (AT) sidney (DOT) com 2006-08-20 23:44
Is this the correct fix? According to the perllocale PD

"LANGUAGE" is a GNU extension, it affects you only if you are
using the GNU libc. This is the case if you are using e.g. Linux.
If you are using "commercial" UNIXes you are most probably not
using GNU libc and you can ignore "LANGUAGE".

Would it be more correct to set both LANGUAGE and LC_ALL to cover both types of
systems?

You are receiving this mail because:
You are the assignee for the bug, or are watching the assignee.

sidney (AT) sidney (DOT) com changed:

What |Removed |Added

Attachment #3636 is|0 |1
obsolete| |

Additional Comments From sidney (AT) sidney (DOT) com 2006-08-21 02:03
Created an attachment (id=3661)
()
Patch to also set LANGUAGE in every case that LC_ALL is being set

This patch gets every place we set LC_ALL, which happens to be only in tests.
It sets LANGUAGE but also leaves LC_ALL being set so it should work with
systems that don't have the GNU extension for LANGUAGE. I guessed at what the
right thing is in lang_pl_tests.t

Patch is against the 3.1 branch. Please review and vote. I'll commit to trunk
when I commit to 3.1.

You are receiving this mail because:
You are the assignee for the bug, or are watching the assignee.

sidney (AT) sidney (DOT) com changed:

What |Removed |Added

Summary|tests fail due to LANGUAGE |[review] tests fail due to
|environment variable |LANGUAGE environment
| |variable
Status Whiteboard| |needs 2 votes

You are receiving this mail because:
You are the assignee for the bug, or are watching the assignee.

Additional Comments From jm (AT) jmason (DOT) org 2006-08-21 23:10
+1
You are receiving this mail because:
You are the assignee for the bug, or are watching the assignee.

jm (AT) jmason (DOT) org changed:
What |Removed |Added
Status Whiteboard|needs 2 votes |needs 1
You are receiving this mail because:
You are the assignee for the bug, or are watching the assignee.

spamassassin (AT) dostech (DOT) ca changed:

What |Removed |Added

Status Whiteboard|needs 1 |can be committed

Additional Comments From spamassassin (AT) dostech (DOT) ca 2006-08-23 04:24
+1

You are receiving this mail because:
You are the assignee for the bug, or are watching the assignee.

sidney (AT) sidney (DOT) com changed:

What |Removed |Added

Status|NEW |RESLVED
Resolution| |FIXED
Status Whiteboard|can be committed |

Additional Comments From sidney (AT) sidney (DOT) com 2006-08-23 04:42
Committed to 3.1 revision 433888.

Committed to trunk revision 433891.

You are receiving this mail because:
You are the assignee for the bug, or are watching the assignee.