Nicholas Clark wrote:
Mon, May 08, 2006 at 09:48:58AM +0100, Steve Hay wrote:
>I don't think so: blead's perl -V doesn't list it and that works fine.
But (as described below) maint is different.
Ah, K. I think makedef.pl can be made to skip Perl_csighandler_va
without the need for any changes to perl -V.
Gisle previously (and quite rightly) objected to things being listed
there when they weren't really compile-time options:
The solution on that occasion was to skip the symbol based on the
platform (Win32), since it's necessity or otherwise was determined by
the platform:
If we go down that road then the attached patch1 does the trick for
Win32, but I'm not sure how many other platforms would need a similar trick.
If many more platforms are affected then perhaps something like patch2
is better? The only thing that worries me there is that
Perl_csighandler_va is defined or otherwise based on the definedness of
HAS_SIGACTIN and SA_SIGINF, but the makedef.pl change is only
considering d_sigaction. Is that good enough?
Radan Computational Ltd.
The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only. If you have received this message in error or there are any problems, please notify the sender immediately. The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden. Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd. The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email.
//#32 - c:\p5p\maintperl\makedef.pl
@@ -287,6 +287,7 @@
Perl_my_pclose
Perl_my_popen
Perl_my_sprintf
+ Perl_csighandler_va
)];
}
else {
//#32 - c:\p5p\maintperl\makedef.pl
@@ -797,6 +797,12 @@
)];
}
+unless ($define{'d_sigaction'}) {
+ skip_symbols [qw(
+ Perl_csighandler_va
+ )];
+}
+
sub readvar {
my $file = shift;
my $proc = shift || sub { "PL_$_[2]" };